Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dcabb507 authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf record: Store PERF_RECORD_FINISHED_ROUND only for nonempty rounds 



Currently we store PERF_RECORD_FINISHED_ROUND event each time
we go throught mmap buffers no matter if it contains any data,
which is useless.

Forcing the PERF_RECORD_FINISHED_ROUND event to be stored any
time we finished the round AND wrote at least one event.

Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Acked-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Acked-by: default avatarDavid Ahern <dsahern@gmail.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jean Pihet <jean.pihet@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1406300177-31805-19-git-send-email-jolsa@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 33bf7481

tools/perf/builtin-record.c

+7 −1
Original line number Diff line number Diff line
@@ -238,6 +238,7 @@ static struct perf_event_header finished_round_event = { 


static int record__mmap_read_all(struct record *rec)

{

	u64 bytes_written = rec->bytes_written;

	int i;

	int rc = 0;
@@ -250,6 +251,11 @@ static int record__mmap_read_all(struct record *rec) 
		}

	}



	/*

	 * Mark the round finished in case we wrote

	 * at least one event.

	 */

	if (bytes_written != rec->bytes_written)

		rc = record__write(rec, &finished_round_event, sizeof(finished_round_event));



out: