Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dbd501a8 authored by Eugenia Emantayev's avatar Eugenia Emantayev Committed by David S. Miller
Browse files

net/mlx4_en: Use the correct netif lock on ndo_set_rx_mode 



The device multicast list is protected by netif_addr_lock_bh in the networking core, we should
use this locking practice in mlx4_en too.

Signed-off-by: default avatarEugenia Emantayev <eugenia@mellanox.com>
Signed-off-by: default avatarAmir Vadai <amirv@mellanox.com>
Reviewed-by: default avatarYevgeny Petrilin <yevgenyp@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent db0e7cba

drivers/net/ethernet/mellanox/mlx4/en_netdev.c

+2 −2
Original line number Diff line number Diff line
@@ -767,9 +767,9 @@ static void mlx4_en_do_set_multicast(struct work_struct *work) 


		/* Update multicast list - we cache all addresses so they won't

		 * change while HW is updated holding the command semaphor */

		netif_tx_lock_bh(dev);

		netif_addr_lock_bh(dev);

		mlx4_en_cache_mclist(dev);

		netif_tx_unlock_bh(dev);

		netif_addr_unlock_bh(dev);

		list_for_each_entry(mclist, &priv->mc_list, list) {

			mcast_addr = mlx4_en_mac_to_u64(mclist->addr);

			mlx4_SET_MCAST_FLTR(mdev->dev, priv->port,