Commit dbb5ff1d authored Jul 13, 2015 by Nikolay Aleksandrov Committed by Sasha Levin Sep 28, 2015

bridge: mdb: fix double add notification



[ Upstream commit 5ebc784625ea68a9570d1f70557e7932988cd1b4 ]

Since the mdb add/del code was introduced there have been 2 br_mdb_notify
calls when doing br_mdb_add() resulting in 2 notifications on each add.

Example:
 Command: bridge mdb add dev br0 port eth1 grp 239.0.0.1 permanent
 Before patch:
 root@debian:~# bridge monitor all
 [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
 [MDB]dev br0 port eth1 grp 239.0.0.1 permanent

 After patch:
 root@debian:~# bridge monitor all
 [MDB]dev br0 port eth1 grp 239.0.0.1 permanent

Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Fixes: cfd56754 ("bridge: add support of adding and deleting mdb entries")
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

parent ce76b83f

net/bridge/br_mdb.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -347,7 +347,6 @@ static int br_mdb_add_group(struct net_bridge br, struct net_bridge_port port,
		return -ENOMEM;
		rcu_assign_pointer(*pp, p);

		br_mdb_notify(br->dev, port, group, RTM_NEWMDB);
		return 0;
		}