Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dbb0dd02 authored by Jose Alonso's avatar Jose Alonso Committed by Martin Schwidefsky
Browse files

s390/qdio: for_each macro correctness 



I observed that there are for_each macros that do an extra memory access
beyond the defined area.
Normally this does not cause problems.
But, this can cause exceptions. For example: if the area is allocated at
the end of a page and the next page is not accessible.

For correctness, I suggest changing the arguments of the 'for loop' like
others 'for_each' do in the kernel.

Signed-off-by: default avatarJose Alonso <joalonsof@gmail.com>
Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent 0e47c969

drivers/s390/cio/qdio.h

+6 −8
Original line number Diff line number Diff line
@@ -360,13 +360,11 @@ static inline int multicast_outbound(struct qdio_q *q) 
	(unlikely(q->irq_ptr->siga_flag.sync_out_after_pci))



#define for_each_input_queue(irq_ptr, q, i)		\

	for (i = 0, q = irq_ptr->input_qs[0];	\

		i < irq_ptr->nr_input_qs;	\

		q = irq_ptr->input_qs[++i])

	for (i = 0; i < irq_ptr->nr_input_qs &&		\

		({ q = irq_ptr->input_qs[i]; 1; }); i++)

#define for_each_output_queue(irq_ptr, q, i)		\

	for (i = 0, q = irq_ptr->output_qs[0];	\

		i < irq_ptr->nr_output_qs;	\

		q = irq_ptr->output_qs[++i])

	for (i = 0; i < irq_ptr->nr_output_qs &&	\

		({ q = irq_ptr->output_qs[i]; 1; }); i++)



#define prev_buf(bufnr)	\

	((bufnr + QDIO_MAX_BUFFERS_MASK) & QDIO_MAX_BUFFERS_MASK)