Commit dba6f385 authored Jun 30, 2010 by Guennadi Liakhovetski Committed by Paul Mundt Aug 04, 2010

fbdev: sh-mobile-lcdc: fix potential Oops in SH-Mobile LCDC framebuffer driver



sh_mobile_lcdc_setup_clocks() can perform IO, therefore it has to be called
after ioremap(). Also check return code of ioremap() and use resource_size()
instead of open-coding it.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Magnus Damm <damm@opensource.se>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>

parent 8a2b6bef

drivers/video/sh_mobile_lcdcfb.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -1020,14 +1020,16 @@ static int __devinit sh_mobile_lcdc_probe(struct platform_device *pdev)
		goto err1;
		}

		priv->base = ioremap_nocache(res->start, resource_size(res));
		if (!priv->base)
		goto err1;

		error = sh_mobile_lcdc_setup_clocks(pdev, pdata->clock_source, priv);
		if (error) {
		dev_err(&pdev->dev, "unable to setup clocks\n");
		goto err1;
		}

		priv->base = ioremap_nocache(res->start, (res->end - res->start) + 1);

		for (i = 0; i < j; i++) {
		cfg = &priv->ch[i].cfg;