Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9b78f33 authored by Kuninori Morimoto's avatar Kuninori Morimoto Committed by Felipe Balbi
Browse files

usb: renesas_usbhs: tidyup for smatch warnings 



This patch tidyup below smatch complaint

drivers/usb/renesas_usbhs/mod_host.c +642 usbhsh_queue_done()
	 warn: variable dereferenced before check 'urb' (see line 636)

Special thanks to Dan

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 15a3838b

drivers/usb/renesas_usbhs/mod_host.c

+1 −2
Original line number Diff line number Diff line
@@ -633,7 +633,6 @@ static void usbhsh_queue_done(struct usbhs_priv *priv, struct usbhs_pkt *pkt) 
	struct usbhsh_hpriv *hpriv = usbhsh_priv_to_hpriv(priv);

	struct usb_hcd *hcd = usbhsh_hpriv_to_hcd(hpriv);

	struct urb *urb = ureq->urb;

	struct usbhsh_ep *uep = usbhsh_ep_to_uep(urb->ep);

	struct device *dev = usbhs_priv_to_dev(priv);

	int status = 0;
@@ -651,7 +650,7 @@ static void usbhsh_queue_done(struct usbhs_priv *priv, struct usbhs_pkt *pkt) 
	usbhsh_ureq_free(hpriv, ureq);



	usbhsh_endpoint_sequence_save(hpriv, urb, pkt);

	usbhsh_pipe_detach(hpriv, uep);

	usbhsh_pipe_detach(hpriv, usbhsh_ep_to_uep(urb->ep));



	usb_hcd_unlink_urb_from_ep(hcd, urb);

	usb_hcd_giveback_urb(hcd, urb, status);