Commit d982057f authored Jul 23, 2013 by Torsten Kaiser Committed by H. Peter Anvin Jul 31, 2013

x86, amd, microcode: Fix error path in apply_microcode_amd()



Return -1 (like Intels apply_microcode) when the loading fails, also
do not set the active microcode level on failure.

Signed-off-by: Torsten Kaiser <just.for.lkml@googlemail.com>
Link: http://lkml.kernel.org/r/20130723225823.2e4e7588@googlemail.com


Acked-by: Borislav Petkov <bp@suse.de>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>

parent f155b630

arch/x86/kernel/microcode_amd.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -220,10 +220,11 @@ int apply_microcode_amd(int cpu)
		return 0;
		}

		if (__apply_microcode_amd(mc_amd))
		if (__apply_microcode_amd(mc_amd)) {
		pr_err("CPU%d: update failed for patch_level=0x%08x\n",
		cpu, mc_amd->hdr.patch_id);
		else
		return -1;
		}
		pr_info("CPU%d: new patch_level=0x%08x\n", cpu,
		mc_amd->hdr.patch_id);