Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d8fe3436 authored by Rajesh Borundia's avatar Rajesh Borundia Committed by David S. Miller
Browse files

qlcnic: Fix potential NULL dereference 



[net-next:master 301/302] drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c:563
 qlcnic_set_multi() error: potential null dereference 'cur'. (kzalloc returns null)

o Break out of the loop after memory allocation failure. Program all the
  MAC addresses that were cached in the return path.

Reported-by: default avatarkbuild test robot <fengguang.wu@intel.com>
Signed-off-by: default avatarRajesh Borundia <rajesh.borundia@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8466563e

drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c

+2 −0
Original line number Diff line number Diff line
@@ -560,6 +560,8 @@ void qlcnic_set_multi(struct net_device *netdev) 
			netdev_for_each_mc_addr(ha, netdev) {

				cur = kzalloc(sizeof(struct qlcnic_mac_list_s),

					      GFP_ATOMIC);

				if (cur == NULL)

					break;

				memcpy(cur->mac_addr,

				       ha->addr, ETH_ALEN);

				list_add_tail(&cur->list, &adapter->vf_mc_list);