Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d8eca110 authored by Axel Lin's avatar Axel Lin Committed by Matthew Garrett
Browse files

asus-laptop: fix a memory leak in asus_laptop_get_info error path 



The callers of write_acpi_int_ret() pass ACPI_ALLOCATE_BUFFER,
the caller must kfree the returned buffer if AE_OK is returned.

This patch adds a missing kfree(buffer.pointer) before return -ENOMEM
if kstrdup fail.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Acked-by: default avatarCorentin Chary <corentincj@iksaif.net>
Signed-off-by: default avatarMatthew Garrett <mjg@redhat.com>
parent 1492616a

drivers/platform/x86/asus-laptop.c

+3 −1
Original line number Diff line number Diff line
@@ -1397,8 +1397,10 @@ static int asus_laptop_get_info(struct asus_laptop *asus) 
		}

	}

	asus->name = kstrdup(string, GFP_KERNEL);

	if (!asus->name)

	if (!asus->name) {

		kfree(buffer.pointer);

		return -ENOMEM;

	}



	if (*string)

		pr_notice("  %s model detected\n", string);