Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d8c39d3f authored by Aaro Koskinen's avatar Aaro Koskinen Committed by Greg Kroah-Hartman
Browse files

staging: octeon-usb: don't retry on data toggle error 



On data toggle error, we don't know if and how many bytes were
successfully transferred by DMA. We should just fail the transaction
instead of trying a retry.

Signed-off-by: default avatarAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e5b90898

drivers/staging/octeon-usb/octeon-hcd.c

+3 −2
Original line number Diff line number Diff line
@@ -2840,8 +2840,9 @@ static int __cvmx_usb_poll_channel(struct cvmx_usb_state *usb, int channel) 
		__cvmx_usb_perform_complete(usb, pipe, transaction,

					    CVMX_USB_COMPLETE_BABBLEERR);

	} else if (usbc_hcint.s.datatglerr) {

		/* We'll retry the exact same transaction again */

		transaction->retries++;

		/* Data toggle error */

		__cvmx_usb_perform_complete(usb, pipe, transaction,

					    CVMX_USB_COMPLETE_DATATGLERR);

	} else if (usbc_hcint.s.nyet) {

		/*

		 * NYET as a response is only allowed in three cases: as a