Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d88a440e authored by Jesper Juhl's avatar Jesper Juhl Committed by Jens Axboe
Browse files

dac960: Remove unused variables from DAC960_CreateProcEntries() 



The variables 'StatusProcEntry' and 'UserCommandProcEntry' are
assigned to once and then never used. This patch gets rid of the
variables.

While I was there I also fixed the indentation of the function to use
tabs rather than spaces for the lines that did not already do so.

Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent d60b9c16

drivers/block/DAC960.c

+10 −13
Original line number Original line Diff line number Diff line
@@ -6580,14 +6580,11 @@ static const struct file_operations dac960_user_command_proc_fops = { 




static void DAC960_CreateProcEntries(DAC960_Controller_T *Controller)

static void DAC960_CreateProcEntries(DAC960_Controller_T *Controller)

{

{

	struct proc_dir_entry *StatusProcEntry;

	struct proc_dir_entry *ControllerProcEntry;

	struct proc_dir_entry *ControllerProcEntry;

	struct proc_dir_entry *UserCommandProcEntry;





	if (DAC960_ProcDirectoryEntry == NULL) {

	if (DAC960_ProcDirectoryEntry == NULL) {

		DAC960_ProcDirectoryEntry = proc_mkdir("rd", NULL);

		DAC960_ProcDirectoryEntry = proc_mkdir("rd", NULL);

  		StatusProcEntry = proc_create("status", 0,

		proc_create("status", 0, DAC960_ProcDirectoryEntry,

					   DAC960_ProcDirectoryEntry,

			    &dac960_proc_fops);

			    &dac960_proc_fops);

	}

	}
@@ -6596,7 +6593,7 @@ static void DAC960_CreateProcEntries(DAC960_Controller_T *Controller) 
					 DAC960_ProcDirectoryEntry);

					 DAC960_ProcDirectoryEntry);

	proc_create_data("initial_status", 0, ControllerProcEntry, &dac960_initial_status_proc_fops, Controller);

	proc_create_data("initial_status", 0, ControllerProcEntry, &dac960_initial_status_proc_fops, Controller);

	proc_create_data("current_status", 0, ControllerProcEntry, &dac960_current_status_proc_fops, Controller);

	proc_create_data("current_status", 0, ControllerProcEntry, &dac960_current_status_proc_fops, Controller);

      UserCommandProcEntry = proc_create_data("user_command", S_IWUSR | S_IRUSR, ControllerProcEntry, &dac960_user_command_proc_fops, Controller);

	proc_create_data("user_command", S_IWUSR | S_IRUSR, ControllerProcEntry, &dac960_user_command_proc_fops, Controller);

	Controller->ControllerProcEntry = ControllerProcEntry;

	Controller->ControllerProcEntry = ControllerProcEntry;

}

}