Commit d8859bea authored Aug 12, 2015 by Sarangdhar Joshi

coresight: fix nr_addr_cmp check in etmv4 driver



nr_addr_cmp variable is incorrectly compared with "true" in
an IF conditin and we end up not setting SSSTATUS bit of
View Instruction control register when nr_addr_cmp != 1. ARM
ETMv4 spec recommends setting SSSTATUS bit for ETM tracing.
Fix this in driver.

Change-Id: Ib6ded122d754bbb0c01e273de59ad93afd2e20f5
Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>

parent 40b49a34

drivers/coresight/coresight-etmv4.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -552,7 +552,7 @@ static void etm_reset_data(struct etm_drvdata *drvdata)
	* each trace run.		* each trace run.
	*/		*/
	drvdata->vinst_ctrl \|= BIT(0);		drvdata->vinst_ctrl \|= BIT(0);
	if (drvdata->nr_addr_cmp == true) {		if (drvdata->nr_addr_cmp) {
	drvdata->mode \|= ETM_MODE_VIEWINST_STARTSTOP;		drvdata->mode \|= ETM_MODE_VIEWINST_STARTSTOP;
	drvdata->vinst_ctrl \|= BIT(9);		drvdata->vinst_ctrl \|= BIT(9);
	}		}