Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d8596403 authored by Anton Vasilyev's avatar Anton Vasilyev Committed by Greg Kroah-Hartman
Browse files

gpio: ml-ioh: Fix buffer underwrite on probe error path 



[ Upstream commit 4bf4eed44bfe288f459496eaf38089502ef91a79 ]

If ioh_gpio_probe() fails on devm_irq_alloc_descs() then chip may point
to any element of chip_save array, so reverse iteration from pointer chip
may become chip_save[-1] and gpiochip_remove() will operate with wrong
memory.

The patch fix the error path of ioh_gpio_probe() to correctly bypass
chip_save array.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarAnton Vasilyev <vasilyev@ispras.ru>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 04924815

drivers/gpio/gpio-ml-ioh.c

+2 −1
Original line number Diff line number Diff line
@@ -495,9 +495,10 @@ err_irq_alloc_descs: 


	chip = chip_save;

err_gpiochip_add:

	chip = chip_save;

	while (--i >= 0) {

		chip--;

		gpiochip_remove(&chip->gpio);

		chip++;

	}

	kfree(chip_save);