Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d832d743 authored by Steven Rostedt (Red Hat)'s avatar Steven Rostedt (Red Hat) Committed by Steven Rostedt
Browse files

ktest: Don't bother with bisect good or bad on replay 



If git bisect reply is being used in the bisect tests, don't bother
doing the git bisect good or git bisect bad calls. The git bisect
reply will override them anyway, and that's called immediately
after the other two. Going the git bisect (good|bad) is just a
waste of time.

Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent 995bc431

tools/testing/ktest/ktest.pl

+8 −6
Original line number Original line Diff line number Diff line
@@ -2736,15 +2736,17 @@ sub bisect { 
    run_command "git bisect start$start_files" or

    run_command "git bisect start$start_files" or

	dodie "could not start bisect";

	dodie "could not start bisect";





    if (defined($replay)) {

	run_command "git bisect replay $replay" or

	    dodie "failed to run replay";

    } else {



	run_command "git bisect good $good" or

	run_command "git bisect good $good" or

	    dodie "could not set bisect good to $good";

	    dodie "could not set bisect good to $good";





	run_git_bisect "git bisect bad $bad" or

	run_git_bisect "git bisect bad $bad" or

	    dodie "could not set bisect bad to $bad";

	    dodie "could not set bisect bad to $bad";





    if (defined($replay)) {

	run_command "git bisect replay $replay" or

	    dodie "failed to run replay";

    }

    }





    if (defined($start)) {

    if (defined($start)) {