Commit d698f1c7 authored Apr 27, 2006 by Eric Sesterhenn Committed by Linus Torvalds Apr 28, 2006

[PATCH] fix array overrun in drivers/char/mwave/mwavedd.c



this fixes coverity id #489.

Since the last element in the array is always ARRAY_SIZE-1 we have to check
for ipcnum >= ARRAY_SIZE()

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 1ac3836c

drivers/char/mwave/mwavedd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -271,7 +271,7 @@ static int mwave_ioctl(struct inode inode, struct file file,
		ipcnum,
		pDrvData->IPCs[ipcnum].usIntCount);

		if (ipcnum > ARRAY_SIZE(pDrvData->IPCs)) {
		if (ipcnum >= ARRAY_SIZE(pDrvData->IPCs)) {
		PRINTK_ERROR(KERN_ERR_MWAVE
		"mwavedd::mwave_ioctl:"
		" IOCTL_MW_REGISTER_IPC:"