Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d66462f5 authored by Alexander van Heukelum's avatar Alexander van Heukelum Committed by Ingo Molnar
Browse files

x86: finalize bitops unification 



include/asm-x86/bitops_32.h and include/asm-x86/bitops_64.h are now
almost identical. The 64-bit version sets ARCH_HAS_FAST_MULTIPLIER
and has an extra inline function set_bit_string. The define currently
has no influence on the generated code, but it can be argued that
setting it on i386 is the right thing to do anyhow. The addition
of the extra inline function on i386 does not hurt either.

Signed-off-by: default avatarAlexander van Heukelum <heukelum@fastmail.fm>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 5245698f

include/asm-x86/bitops.h

+33 −5
Original line number Diff line number Diff line
@@ -403,10 +403,38 @@ static inline int fls(int x) 


#undef ADDR



#ifdef CONFIG_X86_32

# include "bitops_32.h"

#else

# include "bitops_64.h"

#endif

static inline void set_bit_string(unsigned long *bitmap,

		unsigned long i, int len)

{

	unsigned long end = i + len;

	while (i < end) {

		__set_bit(i, bitmap);

		i++;

	}

}



#ifdef __KERNEL__



#include <asm-generic/bitops/sched.h>



#define ARCH_HAS_FAST_MULTIPLIER 1



#include <asm-generic/bitops/hweight.h>



#endif /* __KERNEL__ */



#include <asm-generic/bitops/fls64.h>



#ifdef __KERNEL__



#include <asm-generic/bitops/ext2-non-atomic.h>



#define ext2_set_bit_atomic(lock, nr, addr)			\

	test_and_set_bit((nr), (unsigned long *)(addr))

#define ext2_clear_bit_atomic(lock, nr, addr)			\

	test_and_clear_bit((nr), (unsigned long *)(addr))



#include <asm-generic/bitops/minix.h>



#endif /* __KERNEL__ */

#endif	/* _ASM_X86_BITOPS_H */

include/asm-x86/bitops_32.h

deleted100644 → 0
+0 −30
Original line number Diff line number Diff line 
#ifndef _I386_BITOPS_H

#define _I386_BITOPS_H



/*

 * Copyright 1992, Linus Torvalds.

 */

#ifdef __KERNEL__



#include <asm-generic/bitops/sched.h>



#include <asm-generic/bitops/hweight.h>



#endif /* __KERNEL__ */



#include <asm-generic/bitops/fls64.h>



#ifdef __KERNEL__



#include <asm-generic/bitops/ext2-non-atomic.h>



#define ext2_set_bit_atomic(lock, nr, addr)			\

	test_and_set_bit((nr), (unsigned long *)(addr))

#define ext2_clear_bit_atomic(lock, nr, addr)			\

	test_and_clear_bit((nr), (unsigned long *)(addr))



#include <asm-generic/bitops/minix.h>



#endif /* __KERNEL__ */



#endif /* _I386_BITOPS_H */

include/asm-x86/bitops_64.h

deleted100644 → 0
+0 −42
Original line number Diff line number Diff line 
#ifndef _X86_64_BITOPS_H

#define _X86_64_BITOPS_H



/*

 * Copyright 1992, Linus Torvalds.

 */

static inline void set_bit_string(unsigned long *bitmap, unsigned long i,

				  int len)

{

	unsigned long end = i + len;

	while (i < end) {

		__set_bit(i, bitmap);

		i++;

	}

}



#ifdef __KERNEL__



#include <asm-generic/bitops/sched.h>



#define ARCH_HAS_FAST_MULTIPLIER 1



#include <asm-generic/bitops/hweight.h>



#endif /* __KERNEL__ */



#include <asm-generic/bitops/fls64.h>



#ifdef __KERNEL__



#include <asm-generic/bitops/ext2-non-atomic.h>



#define ext2_set_bit_atomic(lock, nr, addr)			\

	test_and_set_bit((nr), (unsigned long *)(addr))

#define ext2_clear_bit_atomic(lock, nr, addr)			\

	test_and_clear_bit((nr), (unsigned long *)(addr))



#include <asm-generic/bitops/minix.h>



#endif /* __KERNEL__ */



#endif /* _X86_64_BITOPS_H */