Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d52e2e75 authored by Archit Taneja's avatar Archit Taneja Committed by Tomi Valkeinen
Browse files

OMAPDSS: picodlp panel: handle gpio data in panel driver 



The picodlp panel driver leaves gpio requests to the platform's board file.
These should happen in the panel driver itself.

A platform data struct called picodlp_panel_data already exists to hold gpio
numbers and other platform data. Request all the gpios in the panel driver so
that the board files which use the the panel don't need to do it.

This will help in removing the need for the panel drivers to have platform
related callbacks.

Signed-off-by: default avatarArchit Taneja <archit@ti.com>
parent 3552fb78

drivers/video/omap2/displays/panel-picodlp.c

+20 −1
Original line number Diff line number Diff line
@@ -423,10 +423,13 @@ static int picodlp_panel_probe(struct omap_dss_device *dssdev) 
	struct picodlp_panel_data *picodlp_pdata = get_panel_data(dssdev);

	struct i2c_adapter *adapter;

	struct i2c_client *picodlp_i2c_client;

	int picodlp_adapter_id;

	int r, picodlp_adapter_id;



	dssdev->panel.timings = pico_ls_timings;



	if (!picodlp_pdata)

		return -EINVAL;



	picod = devm_kzalloc(&dssdev->dev, sizeof(*picod), GFP_KERNEL);

	if (!picod)

		return -ENOMEM;
@@ -452,6 +455,22 @@ static int picodlp_panel_probe(struct omap_dss_device *dssdev) 


	dev_set_drvdata(&dssdev->dev, picod);



	if (gpio_is_valid(picodlp_pdata->emu_done_gpio)) {

		r = devm_gpio_request_one(&dssdev->dev,

				picodlp_pdata->emu_done_gpio,

				GPIOF_IN, "DLP EMU DONE");

		if (r)

			return r;

	}



	if (gpio_is_valid(picodlp_pdata->pwrgood_gpio)) {

		r = devm_gpio_request_one(&dssdev->dev,

				picodlp_pdata->pwrgood_gpio,

				GPIOF_OUT_INIT_LOW, "DLP PWRGOOD");

		if (r)

			return r;

	}



	return 0;

}