Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d3f92aec authored by Rasesh Mody's avatar Rasesh Mody Committed by David S. Miller
Browse files

bna: TX Intr Coalescing Fix 



Change Details:
        For Tx IB, IPM was enabled with inter_pkt_timeo of 0. This caused the
Tx IB not to generate interrupt till inter_pkt_count of packets have been
received. Correct definition for BFI_TX_INTERPKT_TIMEO & BFI_TX_INTERPKT_COUNT

Signed-off-by: default avatarRasesh Mody <rmody@brocade.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5216562a

drivers/net/ethernet/brocade/bna/bna_hw_defs.h

+2 −1
Original line number Diff line number Diff line
@@ -46,7 +46,8 @@ 
#define BFI_MAX_INTERPKT_COUNT		0xFF

#define BFI_MAX_INTERPKT_TIMEO		0xF	/* in 0.5us units */

#define BFI_TX_COALESCING_TIMEO		20	/* 20 * 5 = 100us */

#define BFI_TX_INTERPKT_COUNT		32

#define BFI_TX_INTERPKT_COUNT		12	/* Pkt Cnt = 12 */

#define BFI_TX_INTERPKT_TIMEO		15	/* 15 * 0.5 = 7.5us */

#define	BFI_RX_COALESCING_TIMEO		12	/* 12 * 5 = 60us */

#define	BFI_RX_INTERPKT_COUNT		6	/* Pkt Cnt = 6 */

#define	BFI_RX_INTERPKT_TIMEO		3	/* 3 * 0.5 = 1.5us */

drivers/net/ethernet/brocade/bna/bna_tx_rx.c

+1 −1
Original line number Diff line number Diff line
@@ -3569,7 +3569,7 @@ bna_tx_create(struct bna *bna, struct bnad *bnad, 
		if (intr_info->intr_type == BNA_INTR_T_INTX)

			txq->ib.intr_vector = (1 <<  txq->ib.intr_vector);

		txq->ib.coalescing_timeo = tx_cfg->coalescing_timeo;

		txq->ib.interpkt_timeo = 0; /* Not used */

		txq->ib.interpkt_timeo = BFI_TX_INTERPKT_TIMEO;

		txq->ib.interpkt_count = BFI_TX_INTERPKT_COUNT;



		/* TCB */