Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d345a5e5 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

[media] s3c-camif: forever loop in camif_hw_set_source_format() 



Because "i" is unsigned then "i-- >= 0" is always true.  If we don't
find what we are looking for then we loop forever.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent 5c47776a

drivers/media/platform/s3c-camif/camif-regs.c

+4 −4
Original line number Diff line number Diff line
@@ -106,15 +106,15 @@ static const u32 src_pixfmt_map[8][2] = { 
void camif_hw_set_source_format(struct camif_dev *camif)

{

	struct v4l2_mbus_framefmt *mf = &camif->mbus_fmt;

	unsigned int i = ARRAY_SIZE(src_pixfmt_map);

	int i;

	u32 cfg;



	while (i-- >= 0) {

	for (i = ARRAY_SIZE(src_pixfmt_map) - 1; i >= 0; i--) {

		if (src_pixfmt_map[i][0] == mf->code)

			break;

	}



	if (i == 0 && src_pixfmt_map[i][0] != mf->code) {

	if (i < 0) {

		i = 0;

		dev_err(camif->dev,

			"Unsupported pixel code, falling back to %#08x\n",

			src_pixfmt_map[i][0]);