Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d27fa008 authored by Andrey Ryabinin's avatar Andrey Ryabinin Committed by Sasha Levin
Browse files

ipv6/addrlabel: fix ip6addrlbl_get() 



[ Upstream commit e459dfeeb64008b2d23bdf600f03b3605dbb8152 ]

ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded,
ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed,
ip6addrlbl_get() will use about to be free ip6addrlbl_entry pointer.

Fix this by inverting ip6addrlbl_hold() check.

Fixes: 2a8cc6c8 ("[IPV6] ADDRCONF: Support RFC3484 configurable address selection policy table.")
Signed-off-by: default avatarAndrey Ryabinin <aryabinin@virtuozzo.com>
Reviewed-by: default avatarCong Wang <cwang@twopensource.com>
Acked-by: default avatarYOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
parent a64b97e5

net/ipv6/addrlabel.c

+1 −1
Original line number Diff line number Diff line
@@ -558,7 +558,7 @@ static int ip6addrlbl_get(struct sk_buff *in_skb, struct nlmsghdr *nlh) 


	rcu_read_lock();

	p = __ipv6_addr_label(net, addr, ipv6_addr_type(addr), ifal->ifal_index);

	if (p && ip6addrlbl_hold(p))

	if (p && !ip6addrlbl_hold(p))

		p = NULL;

	lseq = ip6addrlbl_table.seq;

	rcu_read_unlock();