Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d233d707 authored by Jon Mason's avatar Jon Mason Committed by David S. Miller
Browse files

sunhme: remove unnecessary setting of skb->dev 



skb->dev is being unnecessarily set during ring init and skb alloc in rx.  It is
already being set to the proper value when eth_type_trans is called on packet
receive, and the skb->dev is not referenced anywhere else in the code.

Signed-off-by: default avatarJon Mason <jdmason@kudzu.us>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8505120e

drivers/net/ethernet/sun/sunhme.c

+0 −3
Original line number Diff line number Diff line
@@ -1249,7 +1249,6 @@ static void happy_meal_clean_rings(struct happy_meal *hp) 
static void happy_meal_init_rings(struct happy_meal *hp)

{

	struct hmeal_init_block *hb = hp->happy_block;

	struct net_device *dev = hp->dev;

	int i;



	HMD(("happy_meal_init_rings: counters to zero, "));
@@ -1270,7 +1269,6 @@ static void happy_meal_init_rings(struct happy_meal *hp) 
			continue;

		}

		hp->rx_skbs[i] = skb;

		skb->dev = dev;



		/* Because we reserve afterwards. */

		skb_put(skb, (ETH_FRAME_LEN + RX_OFFSET + 4));
@@ -2031,7 +2029,6 @@ static void happy_meal_rx(struct happy_meal *hp, struct net_device *dev) 
			}

			dma_unmap_single(hp->dma_dev, dma_addr, RX_BUF_ALLOC_SIZE, DMA_FROM_DEVICE);

			hp->rx_skbs[elem] = new_skb;

			new_skb->dev = dev;

			skb_put(new_skb, (ETH_FRAME_LEN + RX_OFFSET + 4));

			hme_write_rxd(hp, this,

				      (RXFLAG_OWN|((RX_BUF_ALLOC_SIZE-RX_OFFSET)<<16)),