Commit d1e2ad07 authored Dec 17, 2012 by Joe Perches Committed by Linus Torvalds Dec 17, 2012

checkpatch: add --strict test for switch/default missing break



switch default case is sometimes written as "default:;".  This can cause
new cases added below the default to be defective.

Suggest adding a break; after empty default cases to avoid fallthrough
defects.

Fixed indentation in the other semicolon test above it.

Suggested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 88982fea

scripts/checkpatch.pl

+16 −2

Original line number	Diff line number	Diff line
		@@ -3452,6 +3452,20 @@ sub process {
		"Statements terminations use 1 semicolon\n" . $herecurr);
		}

		# check for switch/default statements without a break;
		if ($^V && $^V ge 5.10.0 &&
		defined $stat &&
		$stat =~ /^\+[$;\s](?:case[$;\s]+\w+[$;\s]:[$;\s]\|)[$;\s]\bdefault[$;\s]:[$;\s]*;/g) {
		my $ctx = '';
		my $herectx = $here . "\n";
		my $cnt = statement_rawlines($stat);
		for (my $n = 0; $n < $cnt; $n++) {
		$herectx .= raw_line($linenr, $n) . "\n";
		}
		WARN("DEFAULT_NO_BREAK",
		"switch default: should use break\n" . $herectx);
		}

		# check for gcc specific __FUNCTION__
		if ($line =~ /__FUNCTION__/) {
		WARN("USE_FUNC",