Commit d129a8e1 authored Dec 07, 2017 by Takuo Koguchi Committed by Greg Kroah-Hartman Feb 25, 2018

spi: sun4i: disable clocks in the remove function




[ Upstream commit c810daba0ab5226084a56893a789af427a801146 ]

mclk and hclk need to be disabled. Since pm_runtime_disable does
not disable the clocks, use pm_runtime_force_suspend instead.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Takuo Koguchi <takuo.koguchi.sw@hitachi.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f95b33d6

drivers/spi/spi-sun4i.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -458,7 +458,7 @@ err_free_master:

		static int sun4i_spi_remove(struct platform_device *pdev)
		{
		pm_runtime_disable(&pdev->dev);
		pm_runtime_force_suspend(&pdev->dev);

		return 0;
		}