Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0a71a7e authored by Sebastian Haas's avatar Sebastian Haas Committed by Marc Kleine-Budde
Browse files

can: ems_usb: Removed double netif_device_detach 



netif_device_attched is called twice when ems_usb_start fails with -ENODEV

Signed-off-by: default avatarSebastian Haas <dev@sebastianhaas.info>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 44b0052c

drivers/net/can/usb/ems_usb.c

+0 −9
Original line number Diff line number Diff line
@@ -627,9 +627,6 @@ static int ems_usb_start(struct ems_usb *dev) 


		err = usb_submit_urb(urb, GFP_KERNEL);

		if (err) {

			if (err == -ENODEV)

				netif_device_detach(dev->netdev);



			usb_unanchor_urb(urb);

			usb_free_coherent(dev->udev, RX_BUFFER_SIZE, buf,

					  urb->transfer_dma);
@@ -659,9 +656,6 @@ static int ems_usb_start(struct ems_usb *dev) 


	err = usb_submit_urb(dev->intr_urb, GFP_KERNEL);

	if (err) {

		if (err == -ENODEV)

			netif_device_detach(dev->netdev);



		dev_warn(netdev->dev.parent, "intr URB submit failed: %d\n",

			 err);
@@ -692,9 +686,6 @@ static int ems_usb_start(struct ems_usb *dev) 
	return 0;



failed:

	if (err == -ENODEV)

		netif_device_detach(dev->netdev);



	dev_warn(netdev->dev.parent, "couldn't submit control: %d\n", err);



	return err;