Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d04156bc authored by Axel Lin's avatar Axel Lin Committed by Liam Girdwood
Browse files

regulator: tps65910: Add missing breaks in switch/case 



Also add a default case in tps65910_list_voltage_dcdc to silence
'volt' may be used uninitialized in this function warning.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarLiam Girdwood <lrg@slimlogic.co.uk>
parent a3ee13ee

drivers/regulator/tps65910-regulator.c

+7 −0
Original line number Diff line number Diff line
@@ -759,8 +759,13 @@ static int tps65910_list_voltage_dcdc(struct regulator_dev *dev, 
		mult = (selector / VDD1_2_NUM_VOLTS) + 1;

		volt = VDD1_2_MIN_VOLT +

				(selector % VDD1_2_NUM_VOLTS) * VDD1_2_OFFSET;

		break;

	case TPS65911_REG_VDDCTRL:

		volt = VDDCTRL_MIN_VOLT + (selector * VDDCTRL_OFFSET);

		break;

	default:

		BUG();

		return -EINVAL;

	}



	return  volt * 100 * mult;
@@ -898,9 +903,11 @@ static __devinit int tps65910_probe(struct platform_device *pdev) 
	case TPS65910:

		pmic->get_ctrl_reg = &tps65910_get_ctrl_register;

		info = tps65910_regs;

		break;

	case TPS65911:

		pmic->get_ctrl_reg = &tps65911_get_ctrl_register;

		info = tps65911_regs;

		break;

	default:

		pr_err("Invalid tps chip version\n");

		kfree(pmic);