Commit d014e889 authored Oct 02, 2009 by Aaro Koskinen Committed by Ingo Molnar Oct 05, 2009

panic: Fix panic message visibility by calling bust_spinlocks(0) before dying



Commit ffd71da4 ("panic: decrease oops_in_progress only after
having done the panic") moved bust_spinlocks(0) to the end of the
function, which in practice is never reached.

As a result console_unblank() is not called, and on some systems
the user may not see the panic message.

Move it back up to before the unblanking.

Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <1254483680-25578-1-git-send-email-aaro.koskinen@nokia.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 135c8aea

kernel/panic.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -90,6 +90,8 @@ NORET_TYPE void panic(const char * fmt, ...)

		atomic_notifier_call_chain(&panic_notifier_list, 0, buf);

		bust_spinlocks(0);

		if (!panic_blink)
		panic_blink = no_blink;

		@@ -136,7 +138,6 @@ NORET_TYPE void panic(const char * fmt, ...)
		mdelay(1);
		i++;
		}
		bust_spinlocks(0);
		}

		EXPORT_SYMBOL(panic);