Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf89d6b2 authored by Gao feng's avatar Gao feng Committed by David S. Miller
Browse files

neigh: no need to call lookup_neigh_parms in neigh_parms_alloc 



neigh_table.parms always exist and is initialized,kmemdup
can use it to create new neigh_parms, actually lookup_neigh_parms
here will return neigh_table.parms too.

Signed-off-by: default avatarGao feng <gaofeng@cn.fujitsu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 75b29459

net/core/neighbour.c

+2 −6
Original line number Diff line number Diff line
@@ -1429,15 +1429,11 @@ static inline struct neigh_parms *lookup_neigh_parms(struct neigh_table *tbl, 
struct neigh_parms *neigh_parms_alloc(struct net_device *dev,

				      struct neigh_table *tbl)

{

	struct neigh_parms *p, *ref;

	struct neigh_parms *p;

	struct net *net = dev_net(dev);

	const struct net_device_ops *ops = dev->netdev_ops;



	ref = lookup_neigh_parms(tbl, net, 0);

	if (!ref)

		return NULL;



	p = kmemdup(ref, sizeof(*p), GFP_KERNEL);

	p = kmemdup(&tbl->parms, sizeof(*p), GFP_KERNEL);

	if (p) {

		p->tbl		  = tbl;

		atomic_set(&p->refcnt, 1);