Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf78959c authored by Emil Tantilov's avatar Emil Tantilov Committed by Jeff Kirsher
Browse files

ixgbe: fix inconsistent clearing of the multicast table 



This patch resolves an issue where the MTA table can be cleared when the
interface is reset while in promisc mode. As result IPv6 traffic between
VFs will be interrupted.

This patch makes the update of the MTA table unconditional to avoid the
inconsistent clearing on reset.

Signed-off-by: default avatarEmil Tantilov <emil.s.tantilov@intel.com>
Tested-by: default avatarPhil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent f880d07b

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

+7 −8
Original line number Diff line number Diff line
@@ -3823,14 +3823,6 @@ void ixgbe_set_rx_mode(struct net_device *netdev) 
		if (netdev->flags & IFF_ALLMULTI) {

			fctrl |= IXGBE_FCTRL_MPE;

			vmolr |= IXGBE_VMOLR_MPE;

		} else {

			/*

			 * Write addresses to the MTA, if the attempt fails

			 * then we should just turn on promiscuous mode so

			 * that we can at least receive multicast traffic

			 */

			hw->mac.ops.update_mc_addr_list(hw, netdev);

			vmolr |= IXGBE_VMOLR_ROMPE;

		}

		ixgbe_vlan_filter_enable(adapter);

		hw->addr_ctrl.user_set_promisc = false;
@@ -3847,6 +3839,13 @@ void ixgbe_set_rx_mode(struct net_device *netdev) 
		vmolr |= IXGBE_VMOLR_ROPE;

	}



	/* Write addresses to the MTA, if the attempt fails

	 * then we should just turn on promiscuous mode so

	 * that we can at least receive multicast traffic

	 */

	hw->mac.ops.update_mc_addr_list(hw, netdev);

	vmolr |= IXGBE_VMOLR_ROMPE;



	if (adapter->num_vfs)

		ixgbe_restore_vf_multicasts(adapter);