Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf10e82b authored by David Chinner's avatar David Chinner Committed by Lachlan McIlroy
Browse files

[XFS] Fix xfs_ichgtime()s broken usage of I_SYNC 



The recent I_LOCK->I_SYNC changes mistakenly changed xfs_ichgtime to look
at I_SYNC instead of I_LOCK. This was incorrect and prevents newly created
inodes from moving to the dirty list. Change this to the correct check
which is for I_NEW, not I_LOCK or I_SYNC so that behaviour is correct.

SGI-PV: 974225
SGI-Modid: xfs-linux-melb:xfs-kern:30204a

Signed-off-by: default avatarDavid Chinner <dgc@sgi.com>
Signed-off-by: default avatarLachlan McIlroy <lachlan@sgi.com>
parent 978c7b2f

fs/xfs/linux-2.6/xfs_iops.c

+2 −2
Original line number Diff line number Diff line
@@ -117,7 +117,7 @@ xfs_ichgtime( 
	 */

	SYNCHRONIZE();

	ip->i_update_core = 1;

	if (!(inode->i_state & I_SYNC))

	if (!(inode->i_state & I_NEW))

		mark_inode_dirty_sync(inode);

}
@@ -169,7 +169,7 @@ xfs_ichgtime_fast( 
	 */

	SYNCHRONIZE();

	ip->i_update_core = 1;

	if (!(inode->i_state & I_SYNC))

	if (!(inode->i_state & I_NEW))

		mark_inode_dirty_sync(inode);

}