Commit ce0df3d7 authored Nov 16, 2010 by Axel Lin Committed by Mark Brown Nov 16, 2010

ASoC: Fix incorrect kfree in wm8962_probe error path



We allocated memory for wm8962 in wm8962_i2c_probe,
and will free the memory in either wm8962_i2c_probe error path
or wm8962_i2c_remove.

Thus we should not call kfree(wm8962) in wm8962_probe, otherwise
we have double free of wm8962.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent 01cbea32

sound/soc/codecs/wm8962.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -3874,7 +3874,6 @@ err_enable:
		err_get:
		regulator_bulk_free(ARRAY_SIZE(wm8962->supplies), wm8962->supplies);
		err:
		kfree(wm8962);
		return ret;
		}