Commit cdf53441 authored Jul 30, 2012 by Kay Sievers Committed by Linus Torvalds Jul 30, 2012

kmsg: /dev/kmsg - properly return possible copy_from_user() failure



Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Kay Sievers <kay@vrfy.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 5353cf08

kernel/printk.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -389,8 +389,10 @@ static ssize_t devkmsg_writev(struct kiocb iocb, const struct iovec iv,

		line = buf;
		for (i = 0; i < count; i++) {
		if (copy_from_user(line, iv[i].iov_base, iv[i].iov_len))
		if (copy_from_user(line, iv[i].iov_base, iv[i].iov_len)) {
		ret = -EFAULT;
		goto out;
		}
		line += iv[i].iov_len;
		}