Commit cd78dfc6 authored Apr 14, 2009 by Diego Liziero Committed by Liam Girdwood Apr 28, 2009

drivers/regulator: fix when type is different from REGULATOR_VOLTAGE or REGULATOR_CURRENT

When regulator_desc->type is something different from REGULATOR_VOLTAGE or REGULATOR_CURRENT
the if should probably return ERR_PTR(-EINVAL)

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

@@ expression E; constant C; @@
(
- !E == C
+ E != C
)

Signed-off-by: Diego Liziero <diegoliz@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>

parent 036de8ef

drivers/regulator/core.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2001,8 +2001,8 @@ struct regulator_dev regulator_register(struct regulator_desc regulator_desc,
		if (regulator_desc->name == NULL \|\| regulator_desc->ops == NULL)
		return ERR_PTR(-EINVAL);

		if (!regulator_desc->type == REGULATOR_VOLTAGE &&
		!regulator_desc->type == REGULATOR_CURRENT)
		if (regulator_desc->type != REGULATOR_VOLTAGE &&
		regulator_desc->type != REGULATOR_CURRENT)
		return ERR_PTR(-EINVAL);

		if (!init_data)