Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cd5bd3df authored by Jean Delvare's avatar Jean Delvare Committed by Guenter Roeck
Browse files

hwmon: (coretemp) Initialize tmin 



ttarget is initialized when the driver is loaded, but tmin is not.
As a result, tempX_max_hyst attributes read 0. Fix this.

Also use THERM_*_THRESHOLD* constants in these initializations instead
of hard-coding the constants.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Cc: "R, Durgadoss" <durgadoss.r@intel.com>
Cc: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: default avatarGuenter Roeck <guenter.roeck@ericsson.com>
parent 40257b95

drivers/hwmon/coretemp.c

+6 −1
Original line number Diff line number Diff line
@@ -601,7 +601,12 @@ static int create_core_data(struct platform_data *pdata, 
	err = rdmsr_safe_on_cpu(cpu, tdata->intrpt_reg, &eax, &edx);

	if (!err) {

		tdata->attr_size += MAX_THRESH_ATTRS;

		tdata->ttarget = tdata->tjmax - ((eax >> 16) & 0x7f) * 1000;

		tdata->tmin = tdata->tjmax -

			      ((eax & THERM_MASK_THRESHOLD0) >>

			       THERM_SHIFT_THRESHOLD0) * 1000;

		tdata->ttarget = tdata->tjmax -

				 ((eax & THERM_MASK_THRESHOLD1) >>

				  THERM_SHIFT_THRESHOLD1) * 1000;

	}



	pdata->core_data[attr_no] = tdata;