Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc6c2ca3 authored by Chris Elston's avatar Chris Elston Committed by Linus Torvalds
Browse files

rtc: rtc-isl1208: reject invalid dates 



This patch for the rtc-isl1208 driver makes it reject invalid dates.

Signed-off-by: default avatarChris Elston <celston@katalix.com>
[a.zummo@towertech.it: added comment explaining the check]
Signed-off-by: default avatarAlessandro Zummo <a.zummo@towertech.it>
Cc: Hebert Valerio Riedel <hvr@gnu.org>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c47a75a4

drivers/rtc/rtc-isl1208.c

+7 −0
Original line number Diff line number Diff line
@@ -328,6 +328,13 @@ isl1208_i2c_set_time(struct i2c_client *client, struct rtc_time const *tm) 
	int sr;

	u8 regs[ISL1208_RTC_SECTION_LEN] = { 0, };



	/* The clock has an 8 bit wide bcd-coded register (they never learn)

	 * for the year. tm_year is an offset from 1900 and we are interested

	 * in the 2000-2099 range, so any value less than 100 is invalid.

	 */

	if (tm->tm_year < 100)

		return -EINVAL;



	regs[ISL1208_REG_SC] = bin2bcd(tm->tm_sec);

	regs[ISL1208_REG_MN] = bin2bcd(tm->tm_min);

	regs[ISL1208_REG_HR] = bin2bcd(tm->tm_hour) | ISL1208_REG_HR_MIL;