Commit cc56ded3 authored Aug 20, 2013 by Chen Gang Committed by Rusty Russell Aug 20, 2013

kernel/module.c: use scnprintf() instead of sprintf()



For some strings, they are permitted to be larger than PAGE_SIZE, so
need use scnprintf() instead of sprintf(), or it will cause issue.

One case is:

  if a module version is crazy defined (length more than PAGE_SIZE),
  'modinfo' command is still OK (print full contents),
  but for "cat /sys/modules/'modname'/version", will cause issue in kernel.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

parent 5265fc62

kernel/module.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -604,7 +604,7 @@ static void setup_modinfo_##field(struct module mod, const char s) \
		static ssize_t show_modinfo_##field(struct module_attribute *mattr, \
		struct module_kobject mk, char buffer) \
		{ \
		return sprintf(buffer, "%s\n", mk->mod->field); \
		return scnprintf(buffer, PAGE_SIZE, "%s\n", mk->mod->field); \
		} \
		static int modinfo_##field##_exists(struct module *mod) \
		{ \