Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc4d44fc authored by Manoj Prabhu B's avatar Manoj Prabhu B
Browse files

diag: Fix possible access to freed variable 



Mdlog structure member - hdlc timer is being accessed after
mdlog session is terminated.
This patch prevents the access to freed variable
by providing session_lock protection.

Change-Id: I1701e57fb4bbb751b76a4f24dc936ac22524e26c
Signed-off-by: default avatarManoj Prabhu B <bmanoj@codeaurora.org>
parent de631022

drivers/char/diag/diagfwd.c

+2 −0
Original line number Diff line number Diff line
@@ -1268,6 +1268,7 @@ static uint8_t hdlc_reset; 


static void hdlc_reset_timer_start(struct diag_md_session_t *info)

{

	mutex_lock(&driver->md_session_lock);

	if (!hdlc_timer_in_progress) {

		hdlc_timer_in_progress = 1;

		if (info)
@@ -1277,6 +1278,7 @@ static void hdlc_reset_timer_start(struct diag_md_session_t *info) 
			mod_timer(&driver->hdlc_reset_timer,

			  jiffies + msecs_to_jiffies(200));

	}

	mutex_unlock(&driver->md_session_lock);

}



static void hdlc_reset_timer_func(unsigned long data)