Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc30137a authored by Bartlomiej Zolnierkiewicz's avatar Bartlomiej Zolnierkiewicz
Browse files

ide: improve failed opcode reporting 



Nowadays we (almost) always store the currently executing command
in hwif->cmd so we can use it for the failed opcode reporting.

Cc: Martin Lottermoser <Martin.Lottermoser@t-online.de>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
parent 26bfcf21

drivers/ide/ide-lib.c

+4 −19
Original line number Diff line number Diff line
@@ -31,24 +31,6 @@ void ide_toggle_bounce(ide_drive_t *drive, int on) 
		blk_queue_bounce_limit(drive->queue, addr);

}



static void ide_dump_opcode(ide_drive_t *drive)

{

	struct request *rq = drive->hwif->rq;

	struct ide_cmd *cmd = NULL;



	if (!rq)

		return;



	if (rq->cmd_type == REQ_TYPE_ATA_TASKFILE)

		cmd = rq->special;



	printk(KERN_ERR "ide: failed opcode was: ");

	if (cmd == NULL)

		printk(KERN_CONT "unknown\n");

	else

		printk(KERN_CONT "0x%02x\n", cmd->tf.command);

}



u64 ide_get_lba_addr(struct ide_cmd *cmd, int lba48)

{

	struct ide_taskfile *tf = &cmd->tf;
@@ -179,7 +161,10 @@ u8 ide_dump_status(ide_drive_t *drive, const char *msg, u8 stat) 
		else

			ide_dump_atapi_error(drive, err);

	}

	ide_dump_opcode(drive);



	printk(KERN_ERR "%s: possibly failed opcode: 0x%02x\n",

		drive->name, drive->hwif->cmd.tf.command);



	return err;

}

EXPORT_SYMBOL(ide_dump_status);