Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc0be22f authored by taeju.park's avatar taeju.park Committed by Ruchi Kandoi
Browse files

usb: gadget: prevent change of Host MAC address of 'usb0' interface 



On windows 7 platform, previously allocated ip address is maintained.
However, Host MAC address of 'usb0' interface is changed when the
tethering driver re-enumerated. Thus, the tethering network driver
can't be allocated ip address from dhcp. It causes connection delay
between host and phone for usb tethering.

This patch prevents from changing Host MAC address of 'usb0' interface.
In other words, this patch maintains the Host MAC address allocated when
first tethering driver although the driver is re-enumerated. However,
after reboot, the Host MAC address can be changed.

Change-Id: I43add9925e9d6d90c56cffbd3ed999104448f818
Signed-off-by: default avatarBadhri Jagan Sridharan <Badhri@google.com>
parent 25c9b925

drivers/usb/gadget/function/u_ether.c

+18 −3
Original line number Diff line number Diff line
@@ -724,6 +724,8 @@ static int eth_stop(struct net_device *net) 


/*-------------------------------------------------------------------------*/



static u8 host_ethaddr[ETH_ALEN];



static int get_ether_addr(const char *str, u8 *dev_addr)

{

	if (str) {
@@ -756,6 +758,17 @@ static int get_ether_addr_str(u8 dev_addr[ETH_ALEN], char *str, int len) 
	return 18;

}



static int get_host_ether_addr(u8 *str, u8 *dev_addr)

{

	memcpy(dev_addr, str, ETH_ALEN);

	if (is_valid_ether_addr(dev_addr))

		return 0;



	random_ether_addr(dev_addr);

	memcpy(str, dev_addr, ETH_ALEN);

	return 1;

}



static const struct net_device_ops eth_netdev_ops = {

	.ndo_open		= eth_open,

	.ndo_stop		= eth_stop,
@@ -813,9 +826,11 @@ struct eth_dev *gether_setup_name(struct usb_gadget *g, 
	if (get_ether_addr(dev_addr, net->dev_addr))

		dev_warn(&g->dev,

			"using random %s ethernet address\n", "self");

	if (get_ether_addr(host_addr, dev->host_mac))

		dev_warn(&g->dev,

			"using random %s ethernet address\n", "host");



	if (get_host_ether_addr(host_ethaddr, dev->host_mac))

		dev_warn(&g->dev, "using random %s ethernet address\n", "host");

	else

		dev_warn(&g->dev, "using previous %s ethernet address\n", "host");



	if (ethaddr)

		memcpy(ethaddr, dev->host_mac, ETH_ALEN);