Commit cb2d0f3e authored Sep 18, 2011 by David Ward Committed by David S. Miller Oct 04, 2011

macvlan/macvtap: Fix unicast between macvtap interfaces in bridge mode



Packets should always be forwarded to the lowerdev using dev_forward_skb.
vlan->forward is for packets being forwarded directly to another macvlan/
macvtap device (used for multicast in bridge mode).

Reported-and-tested-by: Shlomo Pongratz <shlomop@mellanox.com>
Signed-off-by: David Ward <david.ward@ll.mit.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 976d1676

drivers/net/macvlan.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -239,7 +239,7 @@ static int macvlan_queue_xmit(struct sk_buff skb, struct net_device dev)
		dest = macvlan_hash_lookup(port, eth->h_dest);
		if (dest && dest->mode == MACVLAN_MODE_BRIDGE) {
		/* send to lowerdev first for its network taps */
		vlan->forward(vlan->lowerdev, skb);
		dev_forward_skb(vlan->lowerdev, skb);

		return NET_XMIT_SUCCESS;
		}