Commit cac71121 authored Feb 23, 2009 by Krzysztof Sachanowicz Committed by Linus Torvalds Feb 23, 2009

proc: proc_get_inode should de_put when inode already initialized



de_get is called before every proc_get_inode, but corresponding de_put is
called only when dropping last reference to an inode. This might cause
something like
remove_proc_entry: /proc/stats busy, count=14496
to be printed to the syslog.

The fix is to call de_put in case of an already initialized inode in
proc_get_inode.

Signed-off-by: Krzysztof Sachanowicz <analyzer1@gmail.com>
Tested-by: Marcin Pilipczuk <marcin.pilipczuk@gmail.com>
Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 226485e9

fs/proc/inode.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -485,8 +485,10 @@ struct inode proc_get_inode(struct super_block sb, unsigned int ino,
	}		}
	}		}
	unlock_new_inode(inode);		unlock_new_inode(inode);
	} else		} else {
	module_put(de->owner);		module_put(de->owner);
			de_put(de);
			}
	return inode;		return inode;

	out_ino:		out_ino: