Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c97cf606 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFSv4: Update list of irrecoverable errors on DELEGRETURN 



If the DELEGRETURN errors out with something like NFS4ERR_BAD_STATEID
then there is no recovery possible. Just quit without returning an error.

Also, note that the client must not assume that the NFSv4 lease has been
renewed when it sees an error on DELEGRETURN.

Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
Cc: stable@vger.kernel.org
parent 4a82fd7c

fs/nfs/nfs4proc.c

+8 −2
Original line number Diff line number Diff line
@@ -4988,11 +4988,17 @@ static void nfs4_delegreturn_done(struct rpc_task *task, void *calldata) 


	trace_nfs4_delegreturn_exit(&data->args, &data->res, task->tk_status);

	switch (task->tk_status) {

	case -NFS4ERR_STALE_STATEID:

	case -NFS4ERR_EXPIRED:

	case 0:

		renew_lease(data->res.server, data->timestamp);

		break;

	case -NFS4ERR_ADMIN_REVOKED:

	case -NFS4ERR_DELEG_REVOKED:

	case -NFS4ERR_BAD_STATEID:

	case -NFS4ERR_OLD_STATEID:

	case -NFS4ERR_STALE_STATEID:

	case -NFS4ERR_EXPIRED:

		task->tk_status = 0;

		break;

	default:

		if (nfs4_async_handle_error(task, data->res.server, NULL) ==

				-EAGAIN) {