Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c856197d authored by Peter Senna Tschudin's avatar Peter Senna Tschudin Committed by John W. Linville
Browse files

mwifiex: Change variable type to bool 

The variables cancel_scan_cmd, enable_data, hs_activate and valid are
only assigned the values true and false. Change its type to bool.

The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/

):

@exists@
type T;
identifier b;
@@
- T
+ bool
  b = ...;
  ... when any
  b = \(true\|false\)

Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Acked-by: default avatarBing Zhao <bzhao@marvell.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent e9517fec

drivers/net/wireless/mwifiex/cmdevt.c

+1 −1
Original line number Diff line number Diff line
@@ -1048,7 +1048,7 @@ mwifiex_cancel_pending_ioctl(struct mwifiex_adapter *adapter) 
	struct cmd_ctrl_node *cmd_node = NULL, *tmp_node = NULL;

	unsigned long cmd_flags;

	unsigned long scan_pending_q_flags;

	uint16_t cancel_scan_cmd = false;

	bool cancel_scan_cmd = false;



	if ((adapter->curr_cmd) &&

	    (adapter->curr_cmd->wait_q_enabled)) {

drivers/net/wireless/mwifiex/join.c

+1 −1
Original line number Diff line number Diff line
@@ -621,7 +621,7 @@ int mwifiex_ret_802_11_associate(struct mwifiex_private *priv, 
	int ret = 0;

	struct ieee_types_assoc_rsp *assoc_rsp;

	struct mwifiex_bssdescriptor *bss_desc;

	u8 enable_data = true;

	bool enable_data = true;

	u16 cap_info, status_code;



	assoc_rsp = (struct ieee_types_assoc_rsp *) &resp->params;

drivers/net/wireless/mwifiex/sta_cmd.c

+1 −1
Original line number Diff line number Diff line
@@ -327,7 +327,7 @@ mwifiex_cmd_802_11_hs_cfg(struct mwifiex_private *priv, 
{

	struct mwifiex_adapter *adapter = priv->adapter;

	struct host_cmd_ds_802_11_hs_cfg_enh *hs_cfg = &cmd->params.opt_hs_cfg;

	u16 hs_activate = false;

	bool hs_activate = false;



	if (!hscfg_param)

		/* New Activate command */

drivers/net/wireless/mwifiex/wmm.c

+1 −1
Original line number Diff line number Diff line
@@ -708,7 +708,7 @@ int mwifiex_ret_wmm_get_status(struct mwifiex_private *priv, 
{

	u8 *curr = (u8 *) &resp->params.get_wmm_status;

	uint16_t resp_len = le16_to_cpu(resp->size), tlv_len;

	int valid = true;

	bool valid = true;



	struct mwifiex_ie_types_data *tlv_hdr;

	struct mwifiex_ie_types_wmm_queue_status *tlv_wmm_qstatus;