Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c84d2e72 authored by James Smart's avatar James Smart Committed by Greg Kroah-Hartman
Browse files

Fix driver usage of 128B WQEs when WQ_CREATE is V1. 




[ Upstream commit 3f247de750b8dd8f50a2c1390e2a1238790a9dff ]

There are two versions of a structure for queue creation and setup that the
driver shares with FW. The driver was only treating as version 0.

Verify WQ_CREATE with 128B WQEs in V0 and V1.

Code review of another bug showed the driver passing
128B WQEs and 8 pages in WQ CREATE and V0.
Code inspection/instrumentation showed that the driver
uses V0 in WQ_CREATE and if the caller passes queue->entry_size
128B, the driver sets the hdr_version to V1 so all is good.
When I tested the V1 WQ_CREATE, the mailbox failed causing
the driver to unload.

Signed-off-by: default avatarDick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: default avatarJames Smart <james.smart@broadcom.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 21bdd575

drivers/scsi/lpfc/lpfc_sli.c

+3 −0
Original line number Diff line number Diff line
@@ -13469,6 +13469,9 @@ lpfc_wq_create(struct lpfc_hba *phba, struct lpfc_queue *wq, 
	case LPFC_Q_CREATE_VERSION_1:

		bf_set(lpfc_mbx_wq_create_wqe_count, &wq_create->u.request_1,

		       wq->entry_count);

		bf_set(lpfc_mbox_hdr_version, &shdr->request,

		       LPFC_Q_CREATE_VERSION_1);















		switch (wq->entry_size) {















		default:















		case 64: