Commit c6f89116 authored Apr 30, 2013 by Axel Lin Committed by Mauro Carvalho Chehab May 21, 2013

[media] s5c73m3: Fix off-by-one valid range checking for fie->index



Current code uses fie->index as array subscript, thus the valid value range
is 0 ... ARRAY_SIZE(s5c73m3_intervals) - 1.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 84107253

drivers/media/i2c/s5c73m3/s5c73m3-core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -956,7 +956,7 @@ static int s5c73m3_oif_enum_frame_interval(struct v4l2_subdev *sd,

		if (fie->pad != OIF_SOURCE_PAD)
		return -EINVAL;
		if (fie->index > ARRAY_SIZE(s5c73m3_intervals))
		if (fie->index >= ARRAY_SIZE(s5c73m3_intervals))
		return -EINVAL;

		mutex_lock(&state->lock);