Commit c6edc42f authored Mar 31, 2011 by Hillf Danton Committed by Greg Kroah-Hartman Apr 19, 2011

uio: fix allocating minor id for uio device



The number of uio devices that could be used should be less than
UIO_MAX_DEVICES by design, and this work guards any cases in which id
more than UIO_MAX_DEVICES is utilized.

Signed-off-by: Hillf Danton <dhillf@gmail.com>
Signed-off-by: Hans J. Koch <hjk@hansjkoch.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent f0c554fd

drivers/uio/uio.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -381,7 +381,13 @@ static int uio_get_minor(struct uio_device *idev)
		retval = -ENOMEM;
		goto exit;
		}
		idev->minor = id & MAX_ID_MASK;
		if (id < UIO_MAX_DEVICES) {
		idev->minor = id;
		} else {
		dev_err(idev->dev, "too many uio devices\n");
		retval = -EINVAL;
		idr_remove(&uio_idr, id);
		}
		exit:
		mutex_unlock(&minor_lock);
		return retval;