Commit c6e58110 authored Jul 02, 2014 by Rasmus Villemoes Committed by Mauro Carvalho Chehab Jul 26, 2014

[media] staging: omap4iss: Fix type of struct iss_device::crashed

The crashed member of struct iss_device is documented to be a bitmask,
but a bool doesn't hold that many (usable) bits. Lines 589 and 659 of
iss.c strongly suggest that "unsigned int" was meant (the same type as
struct iss_pipeline::entities). Currently, any crashed entity will be
blamed on index 0, which is unlikely to be what was intended.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

parent 56a65a1e

drivers/staging/media/omap4iss/iss.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -97,7 +97,7 @@ struct iss_device {
		u64 raw_dmamask;

		struct mutex iss_mutex; /* For handling ref_count field */
		bool crashed;
		unsigned int crashed;
		int has_context;
		int ref_count;