Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6e4ae32 authored by Jon Medhurst's avatar Jon Medhurst Committed by Nicolas Pitre
Browse files

ARM: kprobes: Fix emulation of USAD8 instructions 



The USAD8 instruction wasn't being explicitly decoded leading
to the incorrect emulation routine being called. It can be correctly
decoded in the same way as the signed multiply instructions so we move
the decoding there.

Signed-off-by: default avatarJon Medhurst <tixy@yxit.co.uk>
Signed-off-by: default avatarNicolas Pitre <nicolas.pitre@linaro.org>
parent 038c3839

arch/arm/kernel/kprobes-decode.c

+4 −6
Original line number Diff line number Diff line
@@ -1425,11 +1425,6 @@ space_cccc_0111__1(kprobe_opcode_t insn, struct arch_specific_insn *asi) 
	if ((insn & 0x0ff000f0) == 0x03f000f0)

		return INSN_REJECTED;



	/* USADA8 : cccc 0111 1000 xxxx xxxx xxxx 0001 xxxx */

	/* USAD8  : cccc 0111 1000 xxxx 1111 xxxx 0001 xxxx */

	if ((insn & 0x0ff000f0) == 0x07800010)

		 return prep_emulate_rd16rn12rs8rm0_wflags(insn, asi);



	/* SMLALD : cccc 0111 0100 xxxx xxxx xxxx 00x1 xxxx */

	/* SMLSLD : cccc 0111 0100 xxxx xxxx xxxx 01x1 xxxx */

	if ((insn & 0x0ff00090) == 0x07400010)
@@ -1441,8 +1436,11 @@ space_cccc_0111__1(kprobe_opcode_t insn, struct arch_specific_insn *asi) 
	/* SMUSD  : cccc 0111 0000 xxxx 1111 xxxx 01x1 xxxx :  */

	/* SMMLA  : cccc 0111 0101 xxxx xxxx xxxx 00x1 xxxx :  */

	/* SMMUL  : cccc 0111 0101 xxxx 1111 xxxx 00x1 xxxx :  */

	/* USADA8 : cccc 0111 1000 xxxx xxxx xxxx 0001 xxxx :  */

	/* USAD8  : cccc 0111 1000 xxxx 1111 xxxx 0001 xxxx :  */

	if ((insn & 0x0ff00090) == 0x07000010 ||

	    (insn & 0x0ff000d0) == 0x07500010) {

	    (insn & 0x0ff000d0) == 0x07500010 ||

	    (insn & 0x0ff000f0) == 0x07800010) {



		if ((insn & 0x0000f000) == 0x0000f000) {

			return prep_emulate_rd16rs8rm0_wflags(insn, asi);