Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6b2fca8 authored by Andrew Vasquez's avatar Andrew Vasquez Committed by James Bottomley
Browse files

[SCSI] qla2xxx: Correct truncation in return-code status checking. 



QLA_* return codes are 'int' in size.  There were still several
legacy check-points which assumed a return-code width of 8-bits.
This could cause incorrect assumptions of 'good' status if a
return of QLA_FUNCTION_TIMEOUT.

Signed-off-by: default avatarAndrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent ee546b6e

drivers/scsi/qla2xxx/qla_init.c

+1 −1
Original line number Diff line number Diff line
@@ -3435,7 +3435,7 @@ qla2x00_abort_isp(scsi_qla_host_t *vha) 
static int

qla2x00_restart_isp(scsi_qla_host_t *vha)

{

	uint8_t		status = 0;

	int status = 0;

	uint32_t wait_time;

	struct qla_hw_data *ha = vha->hw;

	struct req_que *req = ha->req_q_map[0];

drivers/scsi/qla2xxx/qla_os.c

+1 −1
Original line number Diff line number Diff line
@@ -2568,7 +2568,7 @@ qla2x00_do_work(struct scsi_qla_host *vha) 
void qla2x00_relogin(struct scsi_qla_host *vha)

{

	fc_port_t       *fcport;

	uint8_t         status;

	int status;

	uint16_t        next_loopid = 0;

	struct qla_hw_data *ha = vha->hw;