Commit c61fa0d6 authored Jan 13, 2011 by Venkateswararao Jujjuri (JV) Committed by Eric Van Hensbergen Mar 15, 2011

[fs/9p] Plug potential acl leak



In v9fs_get_acl() if __v9fs_get_acl() gets only one of the
dacl/pacl we are not releasing it.

Signed-off-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

parent 521cb40b

fs/9p/acl.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -71,11 +71,15 @@ int v9fs_get_acl(struct inode inode, struct p9_fid fid)
		if (!IS_ERR(dacl) && !IS_ERR(pacl)) {
		set_cached_acl(inode, ACL_TYPE_DEFAULT, dacl);
		set_cached_acl(inode, ACL_TYPE_ACCESS, pacl);
		posix_acl_release(dacl);
		posix_acl_release(pacl);
		} else
		retval = -EIO;

		if (!IS_ERR(dacl))
		posix_acl_release(dacl);

		if (!IS_ERR(pacl))
		posix_acl_release(pacl);

		return retval;
		}