Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c54def7b authored by Jiri Kosina's avatar Jiri Kosina
Browse files

HID: magicmouse: sanity check report size in raw_event() callback 



The report passed to us from transport driver could potentially be
arbitrarily large, therefore we better sanity-check it so that
magicmouse_emit_touch() gets only valid values of raw_id.

Cc: stable@vger.kernel.org
Reported-by: default avatarSteven Vittitoe <scvitti@google.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 5abfe85c

drivers/hid/hid-magicmouse.c

+10 −0
Original line number Diff line number Diff line
@@ -290,6 +290,11 @@ static int magicmouse_raw_event(struct hid_device *hdev, 
		if (size < 4 || ((size - 4) % 9) != 0)

			return 0;

		npoints = (size - 4) / 9;

		if (npoints > 15) {

			hid_warn(hdev, "invalid size value (%d) for TRACKPAD_REPORT_ID\n",

					size);

			return 0;

		}

		msc->ntouches = 0;

		for (ii = 0; ii < npoints; ii++)

			magicmouse_emit_touch(msc, ii, data + ii * 9 + 4);
@@ -307,6 +312,11 @@ static int magicmouse_raw_event(struct hid_device *hdev, 
		if (size < 6 || ((size - 6) % 8) != 0)

			return 0;

		npoints = (size - 6) / 8;

		if (npoints > 15) {

			hid_warn(hdev, "invalid size value (%d) for MOUSE_REPORT_ID\n",

					size);

			return 0;

		}

		msc->ntouches = 0;

		for (ii = 0; ii < npoints; ii++)

			magicmouse_emit_touch(msc, ii, data + ii * 8 + 6);